[3.9] bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine (GH-21852) #21904

miss-islington · 2020-08-17T14:21:29Z

asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method.
This matches the concrete implementations, and the documentation better.
(cherry picked from commit 29f8429)

Co-authored-by: James Weaver james.barrett@bbc.co.uk

https://bugs.python.org/issue40782

…ethod not a coroutine (pythonGH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better. (cherry picked from commit 29f8429) Co-authored-by: James Weaver <james.barrett@bbc.co.uk>

miss-islington · 2020-08-17T14:40:25Z

@jamesba: Status check is done, and it's a success ✅ .

miss-islington requested review from 1st1 and asvetlov as code owners Aug 17, 2020

the-knights-who-say-ni added the CLA signed label Aug 17, 2020

bedevere-bot mentioned this pull request Aug 17, 2020

bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine #21852

Merged

bedevere-bot added the awaiting review label Aug 17, 2020

gvanrossum approved these changes Aug 17, 2020

View changes

bedevere-bot added awaiting merge and removed awaiting review labels Aug 17, 2020

miss-islington merged commit d6bdf6d into python:3.9 Aug 17, 2020
11 checks passed

bedevere-bot removed the awaiting merge label Aug 17, 2020

miss-islington deleted the backport-29f8429-3.9 branch Aug 17, 2020

[3.9] bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine (GH-21852) #21904

[3.9] bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine (GH-21852) #21904

miss-islington commented Aug 17, 2020 •

edited by bedevere-bot

miss-islington commented Aug 17, 2020

[3.9] bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine (GH-21852) #21904

[3.9] bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine (GH-21852) #21904

Conversation

miss-islington commented Aug 17, 2020 • edited by bedevere-bot

miss-islington commented Aug 17, 2020

miss-islington commented Aug 17, 2020 •

edited by bedevere-bot