[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36802: Drop awrite()/aclose(), support await write() and await close() instead #13099

Merged
merged 10 commits into from May 9, 2019

Conversation

Copy link
Contributor

asvetlov commented May 5, 2019

writelines() supports await syntax as well

https://bugs.python.org/issue36802

asvetlov requested a review from gpshead as a code owner May 5, 2019
Copy link
Contributor Author

asvetlov commented May 5, 2019

The PR requires #13098
That's why I've merged that code to this branch.
I'm trying to keep PRs isolated but it is not always possible, sorry.

gpshead removed their request for review May 5, 2019
Doc/library/asyncio-stream.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-stream.rst Outdated Show resolved Hide resolved
return fut
if not self._protocol._paused:
return self._complete_fut
return self._loop.create_task(self.drain())
Copy link
Member

1st1 May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to avoid creating task in majority of the cases, e.g.:

In the stream __init__:

   self._nop = self.loop.create_future()
   self._nop.set_result(None)

and then in _fast_drain:

   if not self._paused:
        return self._nop

Copy link
Contributor Author

asvetlov May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I do almost the same a few lines above.
There is no writer._paused attribute but writer._protocol._paused one (which has undefined state if the protocol is closing).
That's why I have slightly more comlex logic that you mentioned in a comment but the functionality is the same.

Copy link
Member

1st1 May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, never mind. Could you please add a comment before return self._complete_fut that it's a "fast path"?

Copy link
Contributor Author

asvetlov May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

asvetlov commented May 7, 2019

Is the PR good now?

1st1 approved these changes May 9, 2019
asvetlov merged commit a076e4f into python:master May 9, 2019
Copy link

bedevere-bot commented May 9, 2019

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants