Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
I've signed the CLA but it will take one business day to come through should I close this pull request and create new one once the cla goes through?? |
Hi @KrishnaSai2020, welcome to Python! You can wait a few days and use https://check-python-cla.herokuapp.com/ to check the CLA again. |
|
@remilapeyre ok then will do 👍 |
|
@remilapeyre yeah its come through please review |
|
@remilapeyre please review |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
IMHO this is not the correct fix, this just removes the xdg-settings path on macOS, event without changing the comment in the macOS specific path that says macOS also uses the unix behaviour.
A better fix is to catch and ignore PermissionError when starting xdg-settings (not being allowed to start xdg-settings is similar to it not being on the system at all)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@ronaldoussoren so you're suggesting a try except block to catch the permissions error? also how could code it to ignore the error? edit : wait no I could just type pass |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ronaldoussoren: please review the changes made to this pull request. |
|
@ronaldoussoren please re-review the changes that were made |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good to me.
|
Thanks @KrishnaSai2020 for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed Co-authored-by: KrishnaSai2020 <krishnasai.chivukula@gmal.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 9e27bc0) Co-authored-by: Krishna Chivukula <63070026+KrishnaSai2020@users.noreply.github.com>
|
GH-21051 is a backport of this pull request to the 3.9 branch. |
|
@KrishnaSai2020: Thanks for your PR! |
|
GH-21052 is a backport of this pull request to the 3.8 branch. |
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed Co-authored-by: KrishnaSai2020 <krishnasai.chivukula@gmal.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 9e27bc0) Co-authored-by: Krishna Chivukula <63070026+KrishnaSai2020@users.noreply.github.com>
|
@ronaldoussoren np! |
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed Co-authored-by: KrishnaSai2020 <krishnasai.chivukula@gmal.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 9e27bc0) Co-authored-by: Krishna Chivukula <63070026+KrishnaSai2020@users.noreply.github.com> Co-authored-by: Krishna Chivukula <63070026+KrishnaSai2020@users.noreply.github.com>
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed Co-authored-by: KrishnaSai2020 <krishnasai.chivukula@gmal.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 9e27bc0) Co-authored-by: Krishna Chivukula <63070026+KrishnaSai2020@users.noreply.github.com> Co-authored-by: Krishna Chivukula <63070026+KrishnaSai2020@users.noreply.github.com>
* fixed issue 41005: webbrowser fails when xdg-settings cannot be executed Co-authored-by: KrishnaSai2020 <krishnasai.chivukula@gmal.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
bpo-41005: Fixed if/else bug in code
https://bugs.python.org/issue41005