[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

bpo-39028: Performance enhancement in keyword extraction by seberg · Pull Request #17576 · python/cpython

the-knights-who-say-ni

The Wayback Machine - http://web.archive.org/web/20191230061836/https://github.com/python/cpython/pull/17576

Join GitHub today

GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.

Sign up

Conversation

seberg changed the title ENH: Fix performance issue in keyword extraction bpo-39028: Fix performance issue in keyword extraction

Dec 12, 2019

seberg changed the title bpo-39028: Fix performance issue in keyword extraction bpo-39028: Performance enhancement in keyword extraction

Dec 12, 2019

All keywords should first be checked for pointer identity. Only
after that failed for all keywords (unlikely) should unicode
equality be used.
The original code would call unicode equality on any non-matching
keyword argument. Meaning calling it often e.g. when a function
has many kwargs but only the last one is provided.

methane merged commit 75bb07e into python:master

Dec 18, 2019

9 checks passed

Azure Pipelines PR #20191217.42 succeeded

Details

bedevere/issue-number Issue number 39028 found

Details

bedevere/news News entry found in Misc/NEWS.d

continuous-integration/travis-ci/pr The Travis CI build passed

Details