[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

[3.7] bpo-37424: Avoid a hang in subprocess.run timeout output capture (GH-14490) by miss-islington · Pull Request #15898 · python/cpython

bedevere-bot

The Wayback Machine - https://web.archive.org/web/20190917110850/https://github.com/python/cpython/pull/15898

Join GitHub today

GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.

Sign up

Conversation

bpo-37424: Avoid a hang in subprocess.run timeout output capture (GH-… 

…14490)

Fixes a possible hang when using a timeout on subprocess.run() while
capturing output. If the child process spawned its own children or otherwise
connected its stdout or stderr handles with another process, we could hang
after the timeout was reached and our child was killed when attempting to read
final output from the pipes.
(cherry picked from commit 580d278)

Co-authored-by: Gregory P. Smith <greg@krypto.org>

referenced this pull request

Sep 11, 2019

Merged

Azure Pipelines PR #20190911.27 succeeded

Details

bedevere/issue-number Issue number 37424 found

Details

bedevere/maintenance-branch-pr Valid maintenance branch PR title.

bedevere/news News entry found in Misc/NEWS.d

continuous-integration/appveyor/pr AppVeyor build succeeded

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details