Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
We don't want to create another dependency.
Instead, is it better to use plain Python with no external calls.
Instead of an islice() approach, emulate what was done for list_extend() in Objects/listobject.c and for deque_extend() in Modules/_collectionsmodule.c. When "values is self", create a copy first using "list(values)".
The patch also needs tests and a news blurb.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks, I will have a look at those |
4446de1
to
a31e3d5
Compare
b0294a2
to
4302472
Compare
4302472
to
89f6ab2
Compare
|
I made the requested changes I think |
https://bugs.python.org/issue34427