[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36152: IDLE: Remove unused parameter from colorizer #12109

Merged
merged 2 commits into from Mar 1, 2019
Merged

bpo-36152: IDLE: Remove unused parameter from colorizer #12109

merged 2 commits into from Mar 1, 2019

Conversation

Copy link
Contributor

csabella commented Feb 28, 2019 •
edited by bedevere-bot

Remove unused close_when_done parameter from ColorDelegator's close() method.

https://bugs.python.org/issue36152

csabella requested a review from terryjreedy as a code owner Feb 28, 2019
Blurb: add detail on API change.
fab9312 
Omit that both class and instance attribute.
terryjreedy approved these changes Mar 1, 2019
View changes
Copy link
Member

terryjreedy left a comment

I checked idlelib for other accesses to close_when_done. I checked pyshell, percolator, and turtledemo.main for other calls to ColorDelegator.close. None in both cases.

I am being extra careful with the blurb because turtledemo might not be the only external use of the module, although a similar use will not be affected.

csabella merged commit b9f0354 into python:master Mar 1, 2019
Copy link
Contributor

miss-islington commented Mar 1, 2019

Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

csabella deleted the colorizer branch Mar 1, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 1, 2019
bpo-36152: IDLE: Remove unused parameter from colorizer (pythonGH-12109)
f52fb27 
Remove colorizer.ColorDelegator.close_when_done and the corresponding argument of .close().  In IDLE, both have always been None or False since 2007.
(cherry picked from commit b9f0354)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Copy link

bedevere-bot commented Mar 1, 2019

GH-12119 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 1, 2019
bpo-36152: IDLE: Remove unused parameter from colorizer (GH-12109)
70852b1 
Remove colorizer.ColorDelegator.close_when_done and the corresponding argument of .close().  In IDLE, both have always been None or False since 2007.
(cherry picked from commit b9f0354)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

terryjreedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants