[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35598: IDLE: Refactor globals in config_key.py #11377

Closed
wants to merge 14 commits into from

Conversation

Copy link
Contributor

csabella commented Dec 31, 2018

  • Move translate_key to module level and rename some variables. Also refactor check for key in dictionary.
  • Move key tuples to module level

https://bugs.python.org/issue35598

* Move translate_key to module level
* Move key tuples to module level
sth and others added 13 commits Dec 31, 2018
…11373)

Use crypt_r() when available instead of crypt() in the crypt module.

As a nice side effect: This also avoids a memory sanitizer flake as clang msan doesn't know about crypt's internal libc allocated buffer.
…ythonGH-11375)

Add Clang Memory Sanitizer build instrumentation to work around
false positives from the socket and time modules as well as skipping
a couple test_faulthandler tests.
HASH_OBJ_CONSTRUCTOR has always been defined as 0 since I created
hashlib in Python 2.5.  Delete all code associated with it.
Also skip the same tests when using the undefined behavior sanitizer
as they much with the output.

Updates a regex in another test to use multi-line mode so that the ubsan
buildbot should pass again rather than also adding a skip to that one.
Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used.

Defines should check for __sun instead. Reference: http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris

https://bugs.python.org/issue35550
…ython#11385)

* skip test_constructor under msan.

* fix the others as well.

* reuse existing related news entry.

* typo fix
It doesn't know the details of a few less common libc functions.
A minor typo in the output of `python -m test -h`.
A space was missing in between two words.
howmuch -> how much
* Replace the docstrings cache with sys.intern().
* Improve tests.
* Unify names of tp_descr_get and tp_descr_set functions.
Copy link
Contributor Author

csabella commented Dec 31, 2018

Apologies for the noise everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants