[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-79856: IDLE - separate config_key window and frame #11427

Merged
merged 2 commits into from Sep 30, 2022
Merged

gh-79856: IDLE - separate config_key window and frame #11427

merged 2 commits into from Sep 30, 2022

Conversation

Copy link
Contributor

csabella commented Jan 3, 2019 •
edited by terryjreedy

Split dialog class into a Window class and Frame class and adjust tests to match.

csabella requested a review from terryjreedy as a code owner Jan 3, 2019
terryjreedy changed the title bpo-35598: IDLE: Refactor configkey.py window and frame class bpo-35675: IDLE config_key - separate window and frame classes Jan 7, 2019
auvipy suggested changes Jun 2, 2019
View changes
Copy link

auvipy left a comment

rebase

iritkatriel previously requested changes Sep 30, 2022
View changes
Copy link
Member

iritkatriel left a comment

Needs to be rebased.

Copy link

bedevere-bot commented Sep 30, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

iritkatriel added the pending The issue will be closed if no feedback is provided label Sep 30, 2022
terryjreedy changed the title bpo-35675: IDLE config_key - separate window and frame classes bpo-35675: IDLE config_key - separate window and frame Sep 30, 2022
terryjreedy removed awaiting changes pending The issue will be closed if no feedback is provided labels Sep 30, 2022
terryjreedy self-assigned this Sep 30, 2022
terryjreedy changed the title bpo-35675: IDLE config_key - separate window and frame bpo-35675: IDLE - separate config_key window and frame Sep 30, 2022
terryjreedy dismissed iritkatriel’s stale review Sep 30, 2022

Conflick resolved

terryjreedy merged commit 1cc308d into python:main Sep 30, 2022
12 checks passed
Copy link
Contributor

miss-islington commented Sep 30, 2022

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Sep 30, 2022

GH-97683 is a backport of this pull request to the 3.11 branch.

Copy link

bedevere-bot commented Sep 30, 2022

GH-97684 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
bpo-35675: IDLE - separate config_key window and frame (pythonGH-11427)
d28ac0d 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
bpo-35675: IDLE - separate config_key window and frame (pythonGH-11427)
e14c481 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Sep 30, 2022
bpo-35675: IDLE - separate config_key window and frame (GH-11427)
ab2f1a6 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Sep 30, 2022
bpo-35675: IDLE - separate config_key window and frame (GH-11427)
b61a51a 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
terryjreedy changed the title bpo-35675: IDLE - separate config_key window and frame gh-79856: IDLE - separate config_key window and frame Sep 30, 2022
terryjreedy mentioned this pull request Sep 30, 2022
Closed
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
bpo-35675: IDLE - separate config_key window and frame (python#11427)
8fd0e86 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

auvipy

iritkatriel

terryjreedy

Assignees

terryjreedy

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants