[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-24037: Add Argument Clinic converter bool(accept={int}). #485

Merged
merged 4 commits into from Mar 12, 2017
Merged

bpo-24037: Add Argument Clinic converter bool(accept={int}). #485

merged 4 commits into from Mar 12, 2017

Conversation

Copy link
Member

serhiy-storchaka commented Mar 5, 2017

It is used for semantical booleans using 'i' format unit. This allows to not repeat the default value for Python and C and will help in converting to bool in future.

serhiy-storchaka added the type-feature A feature request or enhancement label Mar 5, 2017
Copy link

mention-bot commented Mar 5, 2017

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @ezio-melotti, @Haypo, @doerwalter and @loewis to be potential reviewers.

vadmium reviewed Mar 11, 2017
View changes
Misc/NEWS Outdated
@@ -907,6 +907,10 @@ Build
Tools/Demos
-----------

- bpo-24037: Argument Clinic now uses the converter `bool(accept={int})` rather
of `int` for semantical booleans. This allows to not repeat the default
value for Python and C and will help in converting to `bool` in future.
Copy link
Member

vadmium Mar 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather of → rather than
This allows to not repeat . . . → This avoids repeating . . . [see earlier changes I made regarding “allows to”: https://bugs.python.org/issue26304]

serhiy-storchaka merged commit 202fda5 into python:master Mar 12, 2017
serhiy-storchaka deleted the bpo-24037-clinic-boolint-converter branch Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vadmium

vstinner

duboviy

taleinat

larryhastings

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants