bpo-30876: Relative import from unloaded package now reimports the package #2639

serhiy-storchaka · 2017-07-09T14:18:49Z

instead of failing with SystemError.

Relative import from non-package now fails with ImportError rather than
SystemError.

…ckage instead of failing with SystemError. Relative import from non-package now fails with ImportError rather than SystemError.

mention-bot · 2017-07-09T14:18:53Z

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @pitrou and @ericsnowcurrently to be potential reviewers.

ncoghlan

Actual changes look good to me, but I believe the NEWS snippet can go in Misc/NEWS.d now

ncoghlan · 2017-07-10T06:26:11Z

Misc/NEWS

@@ -10,6 +10,10 @@ What's New in Python 3.7.0 alpha 1?
 Core and Builtins
 -----------------

+- bpo-30876: Relative import from unloaded package now reimports the package


Should this be a file in NEWS.d now?

I wait until blurb 1.0.1 become available on PyPI.

@serhiy-storchaka It seems to be available on PyPi, I just download via pip.

Collecting blurb Downloading blurb-1.0.1-py3-none-any.whl (56kB) 100% |████████████████████████████████| 61kB 547kB/s Installing collected packages: blurb Successfully installed blurb-1.0.1

What exactly command do you use? I used python3 -m pip install --user blurb and it installed blurb-1.0.

If you already have a version of blurb installed, you may need --upgrade to get it to upgrade to the latest one.

I first uninstalled blurb. If install blurb, the --upgrade option doesn't have any effect.

$ python3 -m pip install --user --upgrade blurb Requirement already up-to-date: blurb in /home/serhiy/.local/lib/python3.5/site-packages

I think the problem is because core-workflow add the pre-requirement on PyPI in 1.0.1 version: Requires Python: >=3.6. You can saw it at 1.0.1, since the latest version which didn't require Python 3.6 is 1.0, you will only get 1.0 on Python 3.5 :(

FYI I installed blurb from source:

clone /home/haypo/prog/python/core-workflow

enter blurb/ directory

install flit: sudo python3 -m pip install -U flit

install blurb using flit: sudo python3 -m flit install

(I would also prefer to get it using pip ;-))

serhiy-storchaka · 2017-07-10T12:04:38Z

Blurb 1.0.1 works with 3.5, but requires 3.6, and blurb 1.0 requires 3.5, but works only with 3.6?

brettcannon · 2017-07-10T18:57:53Z

@serhiy-storchaka it's all a mistake because no one updated the blurb.ini file for blurb in the PRs to add Python 3.5 support. I've now fixed it and will do an updated release sometime this week (I'll try to do it today).

And just for reference this was reported in python/core-workflow#159.

brettcannon

Just asking for some changes to use utility code to make test cleanup easier. Otherwise the solution is surprisingly simple. 😄

brettcannon · 2017-07-10T19:04:19Z

Lib/test/test_import/__init__.py

+        try:
+            import package2.submodule1
+            package2.submodule1.submodule2
+        finally:


All of this cleanup can be handled by the test.test_importlib.util.import_state and uncache context managers.

Thank you Brett. I afraid that test.test_importlib.util.import_state does too much, I think test.support.DirsOnSysPath should be enough.

I wondering what is better, provide test files as a part of the source tree, or create them from zero in a temporary directory?

brettcannon · 2017-07-10T19:04:19Z

Lib/test/test_import/__init__.py

+                import submodule1
+            self.assertNotIn('submodule1', sys.modules)
+            self.assertNotIn('submodule2', sys.modules)
+        finally:


Use test.test_importlib.util.import_state to manage sys.path mutations.

…the package (pythonGH-2639) instead of failing with SystemError. Relative import from non-package now fails with ImportError rather than SystemError.. (cherry picked from commit 8a9cd20)

…the package (GH-2639) (#2676) instead of failing with SystemError. Relative import from non-package now fails with ImportError rather than SystemError. (cherry picked from commit 8a9cd20)

* bpo-30876: Relative import from unloaded package now reimports the package instead of failing with SystemError. Relative import from non-package now fails with ImportError rather than SystemError. (cherry picked from commit 8a9cd20) * bpo-18018: Import raises ImportError instead of SystemError if a relative import is attempted without a known parent package. * bpo-26367: importlib.__init__() raises ImportError like builtins.__import__() when ``level`` is specified but without an accompanying package specified.

bpo-30876: Relative import from unloaded package now reimports the pa…

409a6ee

…ckage instead of failing with SystemError. Relative import from non-package now fails with ImportError rather than SystemError.

the-knights-who-say-ni added the CLA signed label Jul 9, 2017

ncoghlan approved these changes Jul 10, 2017

View changes

brettcannon requested changes Jul 10, 2017

View changes

serhiy-storchaka added 3 commits Jul 11, 2017

Merge branch 'master' into import-from-unknown-package

ba2dccf

Use helpers in tests.

1fdaf8b

Trying to use blurb.

633759a

brettcannon approved these changes Jul 11, 2017

View changes

serhiy-storchaka merged commit 8a9cd20 into python:master Jul 12, 2017

serhiy-storchaka deleted the import-from-unknown-package branch Jul 12, 2017

bpo-30876: Relative import from unloaded package now reimports the package #2639

bpo-30876: Relative import from unloaded package now reimports the package #2639

serhiy-storchaka commented Jul 9, 2017

mention-bot commented Jul 9, 2017

ncoghlan left a comment

ncoghlan Jul 10, 2017

serhiy-storchaka Jul 10, 2017

mlouielu Jul 10, 2017

serhiy-storchaka Jul 10, 2017

ncoghlan Jul 10, 2017

serhiy-storchaka Jul 10, 2017

mlouielu Jul 10, 2017 •

edited

vstinner Jul 10, 2017

serhiy-storchaka commented Jul 10, 2017

brettcannon commented Jul 10, 2017

brettcannon left a comment

brettcannon Jul 10, 2017

serhiy-storchaka Jul 11, 2017

brettcannon Jul 10, 2017

bpo-30876: Relative import from unloaded package now reimports the package #2639

bpo-30876: Relative import from unloaded package now reimports the package #2639

Conversation

serhiy-storchaka commented Jul 9, 2017

mention-bot commented Jul 9, 2017

ncoghlan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlouielu Jul 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serhiy-storchaka commented Jul 10, 2017

brettcannon commented Jul 10, 2017

brettcannon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlouielu Jul 10, 2017 •

edited