[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30814, bpo-30876: Add new import test files to projects. #2851

Merged
merged 1 commit into from Jul 27, 2017
Merged

bpo-30814, bpo-30876: Add new import test files to projects. #2851

merged 1 commit into from Jul 27, 2017

Conversation

Copy link
Member

serhiy-storchaka commented Jul 24, 2017 •
edited by bedevere-bot

I forget to include directories with new test files in the list of the library directories. This caused that these test files were not installed.

https://bugs.python.org/issue30814
bpo-30814, bpo-30876: Add new import test files to projects.
Loading status checks…
65614da
serhiy-storchaka requested a review from ned-deily Jul 24, 2017
ned-deily requested a review from zooba Jul 24, 2017
ned-deily approved these changes Jul 24, 2017
View changes
Copy link
Member

ned-deily left a comment •
edited

The Makefile changes LGTM, thanks! Note that only bpo-30876 was backported to 3.5, so only part of these changes need to go there and should be cherry-picked for 3.5.4 final.
vstinner approved these changes Jul 24, 2017
View changes
Copy link
Member

vstinner commented Jul 24, 2017

I guess that you tested an installed Python on Linux?
Copy link
Member Author

serhiy-storchaka commented Jul 27, 2017

No, I didn't test it.
Copy link
Member Author

serhiy-storchaka commented Jul 27, 2017

Tested. Tests are passed.
serhiy-storchaka merged commit d5ed47d into python:master Jul 27, 2017
3 checks passed
3 checks passed
bedevere/issue-number Issue number 30814 found
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
serhiy-storchaka deleted the serhiy-storchaka:test-import-files branch Jul 27, 2017
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2017
[3.6] bpo-30814, bpo-30876: Add new import test files to projects. (p…
94e3a44 
…ythonGH-2851).

(cherry picked from commit d5ed47d)
Copy link

bedevere-bot commented Jul 27, 2017

GH-2912 is a backport of this pull request to the 3.6 branch.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2017
[3.5] bpo-30814, bpo-30876: Add new import test files to projects. (p…
aed821e 
…ythonGH-2851).

(cherry picked from commit d5ed47d)
Copy link

bedevere-bot commented Jul 27, 2017

GH-2913 is a backport of this pull request to the 3.5 branch.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2017
[3.5] bpo-30876: Add new import test files to projects. (pythonGH-2851).
a0f4061 
(cherry picked from commit d5ed47d)
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2017
[3.6] bpo-30814, bpo-30876: Add new import test files to projects. (G…
Loading status checks…
95b16a9 
…H-2851). (#2912)

(cherry picked from commit d5ed47d)
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2017
[3.5] bpo-30876: Add new import test files to projects. (GH-2851). (#…
Loading status checks…
f9fbed1 
…2913)

(cherry picked from commit d5ed47d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vstinner

ned-deily

zooba

Assignees
No one assigned
Labels
CLA signed type-tests
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants