[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30249: Improve struct.unpack_from() error messages #6059

Merged
merged 2 commits into from Mar 10, 2018
Merged

bpo-30249: Improve struct.unpack_from() error messages #6059

merged 2 commits into from Mar 10, 2018

Conversation

Copy link
Member

zhangyangyu commented Mar 10, 2018 •
edited by bedevere-bot

zhangyangyu added the type-feature A feature request or enhancement label Mar 10, 2018
serhiy-storchaka reviewed Mar 10, 2018
View changes
Modules/_struct.c Outdated
if (offset < 0) {
if (offset + self->s_size > 0) {
PyErr_Format(StructError,
"no space to unpack %zd bytes at offset %zd",
Copy link
Member

serhiy-storchaka Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would better sound as "not enough data" or like.

Copy link
Member Author

zhangyangyu Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. That's my first draft.

zhangyangyu merged commit c10b288 into python:master Mar 10, 2018
zhangyangyu deleted the issue30249 branch Mar 10, 2018
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
bpo-30249: Improve struct.unpack_from() error messages (pythonGH-6059)
1cf765b
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-30249: Improve struct.unpack_from() error messages (pythonGH-6059)
4599d82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants