[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandler #11398

Merged
merged 6 commits into from Sep 11, 2019
Merged

bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandler #11398

merged 6 commits into from Sep 11, 2019

Conversation

Copy link
Contributor

maggyero commented Jan 2, 2019 •
edited by bedevere-bot

Copy link
Member

tirkarthi commented Jan 2, 2019

Please raise an issue in https://bugs.python.org for this PR to discuss this since it's a non-trivial change and would require tests.

Copy link
Contributor

eamanu commented Jan 2, 2019

This seems a interest. I open a issue https://bugs.python.org/issue35640 to discuss this @tirkarthi @maggyero

eamanu approved these changes Jan 2, 2019
View changes
Copy link
Contributor

eamanu left a comment •
edited

LGTM. @maggyero Maybe you will need some Exception control.

maggyero changed the title Allow passing PathLike arguments to SimpleHTTPRequestHandler bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandler Jan 2, 2019
Copy link
Member

JulienPalard commented Mar 15, 2019

Hi @maggyero thanks for the PR!

Could you also provide a .. versionchanged:: in the documentation to tell about it, and a test?

maggyero force-pushed the patch-4 branch 3 times, most recently from 6558433 to 3afec10 Compare Mar 17, 2019
Copy link
Contributor Author

maggyero commented Mar 17, 2019

Could you also provide a .. versionchanged:: in the documentation to tell about it, and a test?

@JulienPalard Yes, done.

Copy link
Contributor Author

maggyero commented Sep 3, 2019

@JulienPalard I have made the requested changes. Please review again.

Copy link
Member

zware commented Sep 10, 2019

@maggyero Could you add a NEWS entry for this change?

Copy link
Contributor Author

maggyero commented Sep 10, 2019

@zware Yes, done!

zware requested changes Sep 11, 2019
View changes
Copy link
Member

zware left a comment

One last thing that I'll commit myself if GitHub lets me, otherwise LGTM.

Doc/library/http.server.rst Outdated Show resolved Hide resolved
Copy link

bedevere-bot commented Sep 11, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Update Doc/library/http.server.rst
d8402f4 
Co-Authored-By: Zachary Ware <zachary.ware@gmail.com>
Copy link
Contributor Author

maggyero commented Sep 11, 2019

I have made the requested changes; please review again.

Copy link

bedevere-bot commented Sep 11, 2019

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

bedevere-bot requested a review from zware Sep 11, 2019
zware approved these changes Sep 11, 2019
View changes
Copy link
Member

zware left a comment

LGTM!

zware merged commit 781266e into python:master Sep 11, 2019
Copy link
Member

zware commented Sep 11, 2019

Thanks for the patch, @maggyero!

maggyero deleted the patch-4 branch Sep 11, 2019
Copy link
Contributor Author

maggyero commented Sep 11, 2019

Thanks for the review @zware!

DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandl…
f29d990 
…er (pythonGH-11398)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
bpo-35640: Allow passing PathLike arguments to SimpleHTTPRequestHandl…
19cc9f4 
…er (pythonGH-11398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

zware

eamanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants