[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

bpo-37328: remove deprecated HTMLParser.unescape #14186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2019
Merged

bpo-37328: remove deprecated HTMLParser.unescape #14186

merged 2 commits into from
Aug 27, 2019

Conversation

Copy link
Member

methane commented Jun 18, 2019 •
edited by bedevere-bot
Loading

It is deprecated since Python 3.4

https://bugs.python.org/issue37328

methane requested a review from ezio-melotti as a code owner June 18, 2019 06:34
Copy link
Member Author

methane commented Jun 18, 2019

Oh! setuptools still depends on this, accidentally.

pypa/setuptools#1788

Copy link
Member Author

methane commented Jun 20, 2019

pypa/setuptools#1788 is fixed.
I wait new setuptools is released and bundled setuptools is upgraded to >=41.0.2

ezio-melotti reviewed Jun 20, 2019
View reviewed changes
Lib/html/parser.py
@@ -9,7 +9,6 @@


import re
import warnings
import _markupbase

from html import unescape
Copy link
Member

ezio-melotti Jun 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be removed too if it's no longer needed (even though removing it might break some code if people are doing from html.parser import unescape instead of from html import unescape).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unescape is used in this module several times.

brettcannon added the type-bug An unexpected behavior, bug, or error label Jun 21, 2019
Copy link
Member

#15483 bumps the setuptools version, so that'll unblock this once merged.

methane closed this Aug 27, 2019
methane reopened this Aug 27, 2019
methane merged commit fae0ed5 into python:master Aug 27, 2019
methane deleted the remove-deprecated-unescape branch August 27, 2019 02:48
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
bpo-37328: remove deprecated HTMLParser.unescape (pythonGH-14186)
b0ada0c 
It is deprecated since Python 3.4.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-37328: remove deprecated HTMLParser.unescape (pythonGH-14186)
09fb900 
It is deprecated since Python 3.4.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
bpo-37328: remove deprecated HTMLParser.unescape (pythonGH-14186)
e22012d 
It is deprecated since Python 3.4.
sanpoChew mentioned this pull request Apr 24, 2023
Merged
3 tasks
methane mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

ezio-melotti ezio-melotti left review comments

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants