[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35733: isinstance(ast.Constant(True), ast.Num) is False #11547

Merged
merged 3 commits into from Jan 18, 2019
Merged

bpo-35733: isinstance(ast.Constant(True), ast.Num) is False #11547

merged 3 commits into from Jan 18, 2019

Conversation

Copy link
Contributor

asottile commented Jan 14, 2019 •
edited by bedevere-bot

asottile mentioned this pull request Jan 14, 2019
Merged
serhiy-storchaka reviewed Jan 14, 2019
View changes
Copy link
Member

serhiy-storchaka left a comment

In general LGTM.

Lib/ast.py Outdated Show resolved Hide resolved
Lib/test/test_ast.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst Outdated Show resolved Hide resolved
Copy link
Contributor Author

asottile commented Jan 14, 2019

Updated! Thanks for the review 🎉

Copy link
Contributor Author

asottile commented Jan 18, 2019

@serhiy-storchaka anything left for me to do here?

serhiy-storchaka merged commit 7417622 into python:master Jan 18, 2019
asottile deleted the bpo_35733 branch Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants