[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Member

Mariatta commented Apr 26, 2017

…(GH-1019).

(cherry picked from commit 9616a82)

Mariatta added the type-bug An unexpected behavior, bug, or error label Apr 26, 2017
Copy link
Member Author

Mariatta commented Apr 26, 2017

@serhiy-storchaka Can you please check if I backported this correctly? There was a conflict in _randommodule.c which I have to resolve manually. Just making sure if everything is still in order.
Thanks :)

serhiy-storchaka requested changes Apr 26, 2017
View reviewed changes
Modules/_randommodule.c Outdated
Copy link
Member

serhiy-storchaka Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint32_t is C99. Use unsigned long instead.

Copy link
Member Author

Mariatta May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed to unsigned long.

Modules/_randommodule.c Outdated
Copy link
Member

serhiy-storchaka Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the 2.7 code at the right hand of assignment.

Copy link
Member Author

Mariatta May 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

Copy link
Member

serhiy-storchaka commented May 13, 2017

Why you have removed the cherry-pick for 2.7 label @brettcannon?

Copy link
Member

brettcannon commented May 13, 2017

@serhiy-storchaka there's an email to python-committers about it, but the label was removed from GitHub entirely so I didn't specifically remove it just for this PR.

Mariatta force-pushed the backport-9616a82-2.7 branch from 2b9bd06 to bd8bc50 Compare May 27, 2017 05:04
Mariatta merged commit 1626a47 into python:2.7 May 27, 2017
Mariatta deleted the backport-9616a82-2.7 branch May 27, 2017 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants