[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-38698: Prevent UnboundLocalError to pop up in parse_message_id (GH-17277) #17476

Merged
merged 1 commit into from Dec 5, 2019
Merged

[3.8] bpo-38698: Prevent UnboundLocalError to pop up in parse_message_id (GH-17277) #17476

merged 1 commit into from Dec 5, 2019

Conversation

Copy link
Contributor

miss-islington commented Dec 5, 2019 •
edited by bedevere-bot

parse_message_id() was improperly using a token defined inside an exception
handler, which was raising UnboundLocalError on parsing an invalid value.

https://bugs.python.org/issue38698
(cherry picked from commit bb81549)

Co-authored-by: Claudiu Popa pcmanticore@gmail.com

https://bugs.python.org/issue38698

bpo-38698: Prevent UnboundLocalError to pop up in parse_message_id (p…
d1e3b99 
…ythonGH-17277)

parse_message_id() was improperly using a token defined inside an exception
handler, which was raising `UnboundLocalError` on parsing an invalid value.

https://bugs.python.org/issue38698
(cherry picked from commit bb81549)

Co-authored-by: Claudiu Popa <pcmanticore@gmail.com>
miss-islington requested a review from a team as a code owner Dec 5, 2019
bedevere-bot mentioned this pull request Dec 5, 2019
Merged
bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Dec 5, 2019
maxking approved these changes Dec 5, 2019
View changes
Copy link
Contributor

maxking left a comment

LGTM

Copy link
Contributor Author

miss-islington commented Dec 5, 2019

@PCManticore: Status check is done, and it's a success ✅ .

miss-islington merged commit e21aa61 into python:3.8 Dec 5, 2019
miss-islington deleted the backport-bb81549-3.8 branch Dec 5, 2019
Copy link
Contributor Author

miss-islington commented Dec 5, 2019

@PCManticore: Status check is done, and it's a success ✅ .

1 similar comment
Copy link
Contributor Author

miss-islington commented Dec 5, 2019

@PCManticore: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

maxking

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants