[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

[3.6] bpo-31238: pydoc ServerThread.stop() clears ref cycle #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.6] bpo-31238: pydoc ServerThread.stop() clears ref cycle #3177

wants to merge 1 commit into from

Conversation

Copy link
Member

vstinner commented Aug 22, 2017 •
edited by bedevere-bot
Loading

ServerThread.stop() now explicitly sets its docserver attribute to
None to break a reference cycle.

https://bugs.python.org/issue31238

bpo-31238: pydoc ServerThread.stop() clears ref cycle
e0c8512 
ServerThread.stop() now explicitly sets its docserver attribute to
None to break a reference cycle.
Copy link
Member Author

For Python 3.6, I chose to not joins the thread as I did in master (PR #3151) since I'm not 100% confident that join() doesn't block too long.

Copy link
Member Author

@pitrou: What do you think of joining or not the thread in Python 3.6?

Copy link
Member

pitrou commented Aug 22, 2017

It's not really a bugfix, so you should leave it alone.

vstinner closed this Aug 22, 2017
vstinner deleted the pydoc36 branch August 22, 2017 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants