[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip #7811

Merged
merged 2 commits into from Jun 20, 2018
Merged

bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip #7811

merged 2 commits into from Jun 20, 2018

Conversation

Copy link
Contributor

srinivasreddy commented Jun 20, 2018

Signed-off-by: Srinivas Reddy Thatiparthy <thatiparthysreenivas@gmail.com>
srinivasreddy requested a review from terryjreedy as a code owner Jun 20, 2018
srinivasreddy changed the title IDLE: In rstrip, rename class RstripExtension as Rstrip bpo-33904: IDLE: In rstrip, rename class RstripExtension as Rstrip Jun 20, 2018
Copy link
Member

terryjreedy left a comment

Thank you. Please add a news item, using blurb. For whatever reason, I cannot push one. Use this:
In module rstrip, rename class RstripExtension as Rstrip.

In the future, please include one with the PR. The exact content does not matter, as it can be edited via the web page, which is much easier than pulling and pushing. This is otherwise ready to merge.

Copy link

bedevere-bot commented Jun 20, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

Copy link
Member

terryjreedy commented Jun 20, 2018

If you are looking for another easy issue, try bpo-33906.

Signed-off-by: Srinivas Reddy Thatiparthy <thatiparthysreenivas@gmail.com>
terryjreedy merged commit 9bb9223 into python:master Jun 20, 2018
Copy link
Contributor

miss-islington commented Jun 20, 2018

Thanks @srinivasreddy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒🤖

Copy link

bedevere-bot commented Jun 20, 2018

GH-7814 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
…ythonGH-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
Copy link

bedevere-bot commented Jun 20, 2018

GH-7815 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
…ythonGH-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 20, 2018
…H-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 20, 2018
…H-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants