[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34251: Restore msilib.Win64 to preserve compatibility #8510

Merged
merged 1 commit into from Jul 28, 2018
Merged

bpo-34251: Restore msilib.Win64 to preserve compatibility #8510

merged 1 commit into from Jul 28, 2018

Conversation

Copy link
Member

berkerpeksag commented Jul 28, 2018 •
edited by bedevere-bot

berkerpeksag requested a review from zware Jul 28, 2018
zware approved these changes Jul 28, 2018
View changes
Copy link
Member

zware left a comment

Whoops. LGTM.

zware merged commit 11eb1a9 into python:master Jul 28, 2018
Copy link
Contributor

miss-islington commented Jul 28, 2018

Thanks @berkerpeksag for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2018
bpo-34251: Restore msilib.Win64 to preserve compatibility (pythonGH-8510
74ce698 
)

(cherry picked from commit 11eb1a9)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
Copy link

bedevere-bot commented Jul 28, 2018

GH-8538 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jul 29, 2018
bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510)
1e98d87 
(cherry picked from commit 11eb1a9)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
berkerpeksag deleted the 34251-msi-constant branch Jul 29, 2018
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-34251: Restore msilib.Win64 to preserve compatibility (pythonGH-8510
912e4c5 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

zware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants