|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
There was a problem hiding this comment.
Looks good.
Now add yourself to Misc/ACKS. :)
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks @ethanfurman, I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
|
Thank you. As soon as I get this on my machine for final checks I'll move it forward. :) |
Honestly, I don't think that it it's still important since we moved to Git: the author is know tracked in Git. Note: There is a "thanks.python.org" project similar to https://thanks.rust-lang.org/ cc @pablogsal |
Sadly, it was cancelled as in the core dev sprint it was decided not worth the maintenance cost. |
|
Thanks @remilapeyre for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…pythonGH-11523) https://bugs.python.org/issue17467 (cherry picked from commit 1fd06f1) Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
|
GH-11669 is a backport of this pull request to the 3.7 branch. |
…GH-11523) (GH-11669) https://bugs.python.org/issue17467 (cherry picked from commit 1fd06f1) Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
https://bugs.python.org/issue17467