[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes bpo-33947: Dataclasses can raise RecursionError in __repr__ #9916

Merged
merged 3 commits into from Oct 19, 2018
Merged

Closes bpo-33947: Dataclasses can raise RecursionError in __repr__ #9916

merged 3 commits into from Oct 19, 2018

Conversation

Copy link
Contributor

srinivasreddy commented Oct 16, 2018 •
edited by bedevere-bot

srinivasreddy requested a review from ericvsmith as a code owner Oct 16, 2018
pppery reviewed Oct 18, 2018
View changes
Lib/dataclasses.py Outdated Show resolved Hide resolved
ericvsmith requested changes Oct 18, 2018
View changes
Copy link
Member

ericvsmith left a comment

Thanks for the PR! See my comments.

Lib/dataclasses.py Show resolved Hide resolved
Lib/dataclasses.py Show resolved Hide resolved
Lib/dataclasses.py Outdated Show resolved Hide resolved
Lib/dataclasses.py Outdated Show resolved Hide resolved
Lib/test/test_dataclasses.py Outdated Show resolved Hide resolved
Lib/test/test_dataclasses.py Show resolved Hide resolved
Misc/NEWS.d/next/Library/2018-10-17-02-15-23.bpo-33947.SRuq3T.rst Outdated Show resolved Hide resolved
Copy link

bedevere-bot commented Oct 18, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

srinivasreddy commented Oct 19, 2018

I have made the requested changes; please review again

Copy link

bedevere-bot commented Oct 19, 2018

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith requested changes Oct 19, 2018
View changes
Copy link
Member

ericvsmith left a comment

Thanks @srinivasreddy, for the quick turnaround.

I have a few small comments. I know they seem insignificant, but it's the same standard that I'd hold myself to, so you get to be the victim of my nitpicking. Thanks in advance.

Lib/test/test_dataclasses.py Outdated Show resolved Hide resolved
Lib/test/test_dataclasses.py Outdated Show resolved Hide resolved
Lib/test/test_dataclasses.py Outdated Show resolved Hide resolved
Lib/test/test_dataclasses.py Outdated Show resolved Hide resolved
Lib/test/test_dataclasses.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2018-10-17-02-15-23.bpo-33947.SRuq3T.rst Outdated Show resolved Hide resolved
Copy link

bedevere-bot commented Oct 19, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor Author

srinivasreddy commented Oct 19, 2018

I have made the requested changes; please review again

Copy link

bedevere-bot commented Oct 19, 2018

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith approved these changes Oct 19, 2018
View changes
Copy link
Member

ericvsmith left a comment

Looks good. Thanks for your work!

ericvsmith merged commit dd13c88 into python:master Oct 19, 2018
5 checks passed
Copy link
Contributor

miss-islington commented Oct 19, 2018

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

Copy link
Contributor

miss-islington commented Oct 19, 2018

Sorry, @srinivasreddy and @ericvsmith, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd13c88b5371e13fc16b84e2f9b8715d917de269 3.6

Copy link
Contributor

miss-islington commented Oct 19, 2018

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

srinivasreddy deleted the 33947_dataclasses branch Oct 19, 2018
serhiy-storchaka added type-bug needs backport to 3.7 and removed needs backport to 3.7 labels Oct 31, 2018
Copy link
Contributor

miss-islington commented Oct 31, 2018

Thanks @srinivasreddy for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Copy link
Contributor

miss-islington commented Oct 31, 2018

Sorry, @srinivasreddy and @ericvsmith, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd13c88b5371e13fc16b84e2f9b8715d917de269 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

pppery

ericvsmith

Assignees

ericvsmith

Labels
CLA signed needs backport to 3.7 type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants