[3.7] bpo-33947: dataclasses no longer can raise RecursionError in repr (GF9916) #9970

miss-islington · 2018-10-19T16:55:02Z

The reprlib code was copied here instead of importing reprlib. I'm not sure if we really need to avoid the import, but since I expect dataclasses to be more common that reprlib, it seems wise. Plus, the code is small.
(cherry picked from commit dd13c88)

Co-authored-by: Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి) srinivasreddy@users.noreply.github.com

https://bugs.python.org/issue33947

…9916) The reprlib code was copied here instead of importing reprlib. I'm not sure if we really need to avoid the import, but since I expect dataclasses to be more common that reprlib, it seems wise. Plus, the code is small. (cherry picked from commit dd13c88) Co-authored-by: Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి) <srinivasreddy@users.noreply.github.com>

miss-islington · 2018-10-19T17:12:32Z

@srinivasreddy and @ericvsmith: Status check is done, and it's a success ✅ .

miss-islington · 2018-10-19T17:13:08Z

@srinivasreddy and @ericvsmith: Status check is done, and it's a success ✅ .

bedevere-bot · 2018-10-19T17:28:33Z

@ericvsmith: Please replace # with GH- in the commit message next time. Thanks!

miss-islington requested a review from ericvsmith as a code owner Oct 19, 2018

the-knights-who-say-ni added the CLA signed label Oct 19, 2018

bedevere-bot added the awaiting review label Oct 19, 2018

ericvsmith merged commit b9182aa into python:3.7 Oct 19, 2018
6 checks passed

bedevere-bot removed the awaiting review label Oct 19, 2018

miss-islington deleted the backport-dd13c88-3.7 branch Oct 19, 2018

python / cpython Public

[3.7] bpo-33947: dataclasses no longer can raise RecursionError in repr (GF9916) #9970

[3.7] bpo-33947: dataclasses no longer can raise RecursionError in repr (GF9916) #9970

miss-islington commented Oct 19, 2018 •

edited by bedevere-bot

miss-islington commented Oct 19, 2018

miss-islington commented Oct 19, 2018

bedevere-bot commented Oct 19, 2018

python / cpython Public

[3.7] bpo-33947: dataclasses no longer can raise RecursionError in repr (GF9916) #9970

[3.7] bpo-33947: dataclasses no longer can raise RecursionError in repr (GF9916) #9970

Conversation

miss-islington commented Oct 19, 2018 • edited by bedevere-bot

miss-islington commented Oct 19, 2018

miss-islington commented Oct 19, 2018

bedevere-bot commented Oct 19, 2018

miss-islington commented Oct 19, 2018 •

edited by bedevere-bot