[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35726: Add test for QueueHandler with multiple handlers #11659

Merged
merged 1 commit into from Apr 7, 2019
Merged

bpo-35726: Add test for QueueHandler with multiple handlers #11659

merged 1 commit into from Apr 7, 2019

Conversation

Copy link
Member

tirkarthi commented Jan 23, 2019 •
edited by bedevere-bot

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 23, 2019
Copy link
Member Author

tirkarthi commented Jan 23, 2019

@vsajip @Zheaoli I have created a test based on my understanding of PR #11537 . Feedback welcome if there are any changes to be made.

eamanu approved these changes Jan 23, 2019
View changes
Copy link
Contributor

eamanu left a comment

LGTM.

Copy link
Contributor

Zheaoli commented Jan 24, 2019

@tirkarthi Nice job bro, It's seem good

Copy link
Member Author

tirkarthi commented Apr 7, 2019

Ping @vsajip

vsajip merged commit 2dad960 into python:master Apr 7, 2019
Copy link
Contributor

miss-islington commented Apr 7, 2019

Thanks @tirkarthi for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2019
bpo-35726: Add test for QueueHandler with multiple handlers (pythonGH…
914a586 
…-11659)

(cherry picked from commit 2dad960)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Copy link

bedevere-bot commented Apr 7, 2019

GH-12714 is a backport of this pull request to the 3.7 branch.

Copy link
Contributor

miss-islington commented May 2, 2019

Thanks @tirkarthi for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2019
bpo-35726: Add test for QueueHandler with multiple handlers (pythonGH…
9364605 
…-11659)

(cherry picked from commit 2dad960)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Copy link

bedevere-bot commented May 2, 2019

GH-13061 is a backport of this pull request to the 3.7 branch.

ned-deily pushed a commit that referenced this pull request May 2, 2019
bpo-35726: Add test for QueueHandler with multiple handlers (GH-11659) (
3f8f64e 
GH-13061)

(cherry picked from commit 2dad960)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

eamanu

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants