[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

bpo-38078: IDLE: Don't run internal code in the user namespace #20040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

bpo-38078: IDLE: Don't run internal code in the user namespace #20040

wants to merge 7 commits into from

Conversation

Copy link
Contributor

ZackerySpytz commented May 11, 2020 •
edited by bedevere-bot
Loading

ZackerySpytz requested a review from terryjreedy as a code owner May 11, 2020 22:36
terryjreedy reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments and convert commands to f-strings. I think that this is ready.

Manual tests: start branch IDLE from command line; start with -c "code", restart from Shell menu, restart from editor. I am thinking about automated tests.

terryjreedy requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix bug or close patch. (I would put pyshell changes in a different PR.)

Lib/idlelib/run.py
@@ -583,6 +583,9 @@ def runcode(self, code):
else:
flush_stdout()

def runcommand(self, code):
return self.runcode(code, user=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a file with print(dir()). Run from command line and __file__ is listed. Run from IDLE editor and file is missing. Change False to True and file is listed again. I have no idea how running the setup commands in runscript.run_module_event and pyshell.ModifiedInterpreter.prepend_path in a different dict affect the result of subsequently running a file.

Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member

Unrelated Pipelines failure on Win64

FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\1\s\lib\test\test_asyncio\test_sendfile.py", line 458, in test_sendfile_close_peer_in_the_middle_of_receiving
    self.run_loop(
AssertionError: ConnectionError not raised

Copy link
Member

Closing for now. Even if I fixed this issue, there might be another.

terryjreedy closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

terryjreedy terryjreedy requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants