[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by dutch109
Modified:
1 year, 5 months ago
Reviewers:
rdmurray
CC:
Arfrever, r.david.murray, Claudiu.Popa, devnull_psf.upfronthosting.co.za, desbma
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 5

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/shutil.rst View 1 2 2 chunks +16 lines, -3 lines 0 comments Download
Lib/shutil.py View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
Lib/test/test_shutil.py View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Expand All Messages | Collapse All Messages
r.david.murray
1 year, 5 months ago #1
http://bugs.python.org/review/19840/diff/11321/Doc/library/shutil.rst
File Doc/library/shutil.rst (right):

http://bugs.python.org/review/19840/diff/11321/Doc/library/shutil.rst#newcode298
Doc/library/shutil.rst:298: used.  Otherwise, *src* is copied (using
:func:`shutil.copy2`, but depends
This should just say "is copied using *copy_function*"

http://bugs.python.org/review/19840/diff/11321/Doc/library/shutil.rst#newcode303
Doc/library/shutil.rst:303: If *copy_function* is given, it must be a callable
that will be used to copy
give the required signature here: "a callable that takes two arguments *src* and
*dest*, that will be used to copy *src* to *dest*" if :func:`os.rename` cannot
be used.

http://bugs.python.org/review/19840/diff/11321/Doc/library/shutil.rst#newcode305
Doc/library/shutil.rst:305: :func:`shutil.copytree` as its `copy_function`
parameter, if the source is
Say instead "If the source is a directory, copytree is called, passing it the
copy_function".

http://bugs.python.org/review/19840/diff/11321/Doc/library/shutil.rst#newcode306
Doc/library/shutil.rst:306: a directory. By default, :func:`shutil.copy2` is
used, but any function
Given the above changes, this becomes simply "The default *copy_function* is
*copy2*."

But then let's also add another sentence: "Using :func:`copy` as the
*copy_function* allows the move to succeed when it is not possible to also copy
the metadata, at the expense of not copying any of the metadata."

http://bugs.python.org/review/19840/diff/11321/Doc/library/shutil.rst#newcode315
Doc/library/shutil.rst:315: Added the *copy_function* argument to be able to
provide a custom copy
It is sufficient to say "Added the *copy_function* keyword argument."
Sign in to reply to this message.
Expand All Messages | Collapse All Messages