Issue 16306: Multiple error line for unknown command line parameter

Hi,

I've just came across an insignificant bug in the Python command line 
interface. When using an unknown parameter, the same error appears 
more than once:

$ python3 -a -z
Unknown option: -a
Unknown option: -z
Unknown option: -a
usage: python3 [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.
$ python -a -z
Unknown option: -a
Unknown option: -z
Unknown option: -a
usage: python [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

I've attached the patch for this issue, including the test.

Submitted another patchs for py3k and python 2.7

LGTM.

Hieu Nguyen, can you please submit a contributor form?

http://python.org/psf/contrib/contrib-form/
http://python.org/psf/contrib/

Serhiy, actually I have submitted my contributor form to Petri Lehtinen in  a sprint here in Finland.

New changeset d2df83d7c649 by Ezio Melotti in branch '2.7':
#16306: Fix multiple error messages when unknown command line parameters where passed to the interpreter.  Patch by Hieu Nguyen.
http://hg.python.org/cpython/rev/d2df83d7c649

New changeset 0153c077a0fd by Ezio Melotti in branch '3.2':
#16306: Fix multiple error messages when unknown command line parameters where passed to the interpreter.  Patch by Hieu Nguyen.
http://hg.python.org/cpython/rev/0153c077a0fd

New changeset 7f01121a660d by Ezio Melotti in branch '3.3':
#16306: merge with 3.2.
http://hg.python.org/cpython/rev/7f01121a660d

New changeset 3a1bcb6de167 by Ezio Melotti in branch 'default':
#16306: merge with 3.3.
http://hg.python.org/cpython/rev/3a1bcb6de167

Fixed, thanks for the patch!

You broke the Ubuntu Shared buildbot, could you fix it?
http://buildbot.python.org/all/buildslaves/bolen-ubuntu

Sorry, it's my fault. Here is a patch which should fix the bug.

Actually 2.7 tests should not be broken, but this patch unify 2.7 and 3.x code.

The new patch doesn't seem to be correct:
without the patch:
$ ./python -a -z
Unknown option: -a
Unknown option: -z
usage: ./python [option] ... [-c cmd | -m mod | file | -] [arg] ...

with the patch:
$ ./python -a -z
Unknown option: -a
usage: ./python [option] ... [-c cmd | -m mod | file | -] [arg] ...

A test case for this should also be added.

Thanks, Ezio, for point.

> without the patch:
> $ ./python -a -z
> Unknown option: -a
> Unknown option: -z
> usage: ./python [option] ... [-c cmd | -m mod | file | -] [arg] ...

This behavior isn't correct. Try also "-E -a -z" and "-a -E -z" (also with 3.3.0).

However I found an error in the test in my patch (actually previous test for 2.7 was correct, but not full). Patch updated, new tests added.

> This behavior isn't correct.

Shouldn't python report all the invalid flags passed?

Should not. It happened unintentionally (and inconsistently).

New changeset 6a79e3beb854 by Ezio Melotti in branch '2.7':
#16306: report only the first unknown option and add more tests.  Patch by Serhiy Storchaka.
http://hg.python.org/cpython/rev/6a79e3beb854

New changeset 654a628f5f00 by Ezio Melotti in branch '3.2':
#16306: report only the first unknown option and add more tests.  Patch by Serhiy Storchaka.
http://hg.python.org/cpython/rev/654a628f5f00

New changeset 421a8a5ffbb2 by Ezio Melotti in branch '3.3':
#16306: merge with 3.2.
http://hg.python.org/cpython/rev/421a8a5ffbb2

New changeset 51caa0820fad by Ezio Melotti in branch 'default':
#16306: merge with 3.3.
http://hg.python.org/cpython/rev/51caa0820fad

Buildbots are happy, closing.
Thanks Serhiy for the patches!

messages: + msg176215

messages: + msg176177

messages: + msg176156

assignee: ezio.melotti
resolution: fixed
stage: commit review -> resolved

messages: + msg173805
stage: commit review

messages: + msg173801

nosy: + hieu.nguyen
messages: + msg173716

keywords: + patch