Issue24839
Created on 2015-08-10 18:15 by steve.dower, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| platform_popen.patch | steve.dower, 2015-08-10 18:15 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg248364 - (view) | Author: Steve Dower (steve.dower) * | Date: 2015-08-10 18:15 | |
platform._syscmd_ver() calls platform.popen() which raises a DeprecationWarning. This causes tests with `@skip(platform.machine() == '...')` decorators to fail. The fix is to call `os.popen()` - patch attached. (platform.popen() just raises the warning and then calls os.popen(), so should be no risk here.) Larry - since this causes spurious failures in numpy's test suite, can we get it into 3.5? |
|||
| msg248367 - (view) | Author: Larry Hastings (larry) * | Date: 2015-08-10 20:41 | |
Yes, I'll accept that for 3.5.0. Paste a link to a pull request here at your earliest convenience (and opportunity). |
|||
| msg248372 - (view) | Author: Steve Dower (steve.dower) * | Date: 2015-08-10 21:35 | |
Have you opened up the repo yet? I'm getting "no access" errors from BB. |
|||
| msg248376 - (view) | Author: Larry Hastings (larry) * | Date: 2015-08-10 22:50 | |
Not yet. I'll open it after I release 3.5.0rc1. I'll send email to clp-d and clp-c when I do. I can email you privately too if you like. |
|||
| msg248383 - (view) | Author: Larry Hastings (larry) * | Date: 2015-08-11 00:29 | |
My Bitbucket repo is now public. https://bitbucket.org/larry/cpython350 |
|||
| msg248387 - (view) | Author: Roundup Robot (python-dev) | Date: 2015-08-11 04:03 | |
New changeset 7cfe20a6395d by Steve Dower in branch '3.5': Issue #24839: platform._syscmd_ver raises DeprecationWarning https://hg.python.org/cpython/rev/7cfe20a6395d |
|||
| msg248388 - (view) | Author: Steve Dower (steve.dower) * | Date: 2015-08-11 04:08 | |
PR is at https://bitbucket.org/larry/cpython350/pull-requests/1/issue-24839-platform_syscmd_ver-raises/diff (For my sanity, your 3.5 branch and the hg.p.o 3.5 branch *are* currently in sync, yes? Any value in adding a 3.5.0 branch for your divergence so we can avoid the need for multiple clones?) |
|||
| msg248401 - (view) | Author: Larry Hastings (larry) * | Date: 2015-08-11 10:54 | |
They are currently in sync, yes. The 3.5 branch has been a ghost town the last day or two, which tbh has been pleasant for me.helpfu |
|||
| msg248402 - (view) | Author: Larry Hastings (larry) * | Date: 2015-08-11 11:04 | |
Merged. Please forward-port to 3.5.1 and 3.6. Thanks! (See? Already I can tell this rc-cycle is going to be way easier on me than 3.4 was.) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:19 | admin | set | github: 69027 |
| 2015-08-11 11:04:17 | larry | set | messages: + msg248402 |
| 2015-08-11 10:54:30 | larry | set | messages: + msg248401 |
| 2015-08-11 04:11:22 | steve.dower | set | status: open -> closed resolution: fixed stage: needs patch -> resolved |
| 2015-08-11 04:08:08 | steve.dower | set | messages: + msg248388 |
| 2015-08-11 04:03:55 | python-dev | set | nosy:
+ python-dev messages: + msg248387 |
| 2015-08-11 00:29:05 | larry | set | messages: + msg248383 |
| 2015-08-10 22:50:56 | larry | set | messages: + msg248376 |
| 2015-08-10 21:35:37 | steve.dower | set | messages: + msg248372 |
| 2015-08-10 20:41:40 | larry | set | messages: + msg248367 |
| 2015-08-10 18:15:43 | steve.dower | create | |