Issue33763
Created on 2018-06-04 00:11 by cheryl.sabella, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 7367 | merged | cheryl.sabella, 2018-06-04 00:15 | |
| PR 7399 | merged | miss-islington, 2018-06-04 15:59 | |
| PR 7400 | merged | miss-islington, 2018-06-04 16:00 | |
| Messages (7) | |||
|---|---|---|---|
| msg318588 - (view) | Author: Cheryl Sabella (cheryl.sabella) * | Date: 2018-06-04 00:11 | |
Item 11 from #33610. Use read-only Text instead of Label for context. * Change widget type from Label to Text and remove Label-only arguments. * Add height and state arguments. * Change widget name from self.label to self.context. * Tests: change widget name and method for getting text. |
|||
| msg318637 - (view) | Author: Terry J. Reedy (terry.reedy) * | Date: 2018-06-04 06:07 | |
This makes detecting the context line a user clicks on slightly easier. See new issue #33768 for discussion. I am not sure now I would do this just for this reason, without trying with the label first. Using a text also allows us to experiment with tagging the context keyword somehow, to see if it seems like an improvement. Perhaps make it bold, or underlined, or the normal keyword color, or some variant thereof (grayed?). So I am inclined to go ahead. I did notice that most of the patch is straightforward substitution. To me, this suggests that the code is pretty good. Also, I think change 'label' (implentation) to 'context' (purpose) is a good change by itself. I would keep this even if we reverted to using Label. |
|||
| msg318646 - (view) | Author: Cheryl Sabella (cheryl.sabella) * | Date: 2018-06-04 12:37 | |
To your point, when I was adding the colors to configuration for context, I wondered if having context as a text widget could somehow use the colorizer. I didn't really look into it, but it did seem like it might make sense to keep all the foreground text colors the same as they are in the editor. |
|||
| msg318663 - (view) | Author: Terry J. Reedy (terry.reedy) * | Date: 2018-06-04 15:58 | |
New changeset b609e687a076d77bdd687f5e4def85e29a044bfc by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-33763: IDLE: Replace label widget with text widget in code context (GH-7367) https://github.com/python/cpython/commit/b609e687a076d77bdd687f5e4def85e29a044bfc |
|||
| msg318669 - (view) | Author: miss-islington (miss-islington) | Date: 2018-06-04 16:22 | |
New changeset ffe29dbcd96dc2fbda212f8335908fa1bc8ed893 by Miss Islington (bot) in branch '3.6': bpo-33763: IDLE: Replace label widget with text widget in code context (GH-7367) https://github.com/python/cpython/commit/ffe29dbcd96dc2fbda212f8335908fa1bc8ed893 |
|||
| msg318670 - (view) | Author: miss-islington (miss-islington) | Date: 2018-06-04 16:33 | |
New changeset b7eb1024d06e51598fc8a19ed6e22b91120c6a1e by Miss Islington (bot) in branch '3.7': bpo-33763: IDLE: Replace label widget with text widget in code context (GH-7367) https://github.com/python/cpython/commit/b7eb1024d06e51598fc8a19ed6e22b91120c6a1e |
|||
| msg318676 - (view) | Author: Terry J. Reedy (terry.reedy) * | Date: 2018-06-04 17:02 | |
I believe the colorizer would need some new code, maybe in a subclass, but it should be possible. I would not know if I liked it until we tried it ;-). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:01 | admin | set | github: 77944 |
| 2018-06-04 17:02:38 | terry.reedy | set | status: open -> closed resolution: fixed messages: + msg318676 stage: patch review -> resolved |
| 2018-06-04 16:33:27 | miss-islington | set | messages: + msg318670 |
| 2018-06-04 16:22:14 | miss-islington | set | nosy:
+ miss-islington messages: + msg318669 |
| 2018-06-04 16:00:57 | miss-islington | set | pull_requests: + pull_request7026 |
| 2018-06-04 15:59:54 | miss-islington | set | pull_requests: + pull_request7025 |
| 2018-06-04 15:58:47 | terry.reedy | set | messages: + msg318663 |
| 2018-06-04 12:37:32 | cheryl.sabella | set | messages: + msg318646 |
| 2018-06-04 06:07:29 | terry.reedy | set | messages: + msg318637 |
| 2018-06-04 05:55:37 | terry.reedy | link | issue33768 dependencies |
| 2018-06-04 00:17:45 | cheryl.sabella | link | issue33610 dependencies |
| 2018-06-04 00:15:46 | cheryl.sabella | set | keywords:
+ patch stage: patch review pull_requests: + pull_request6993 |
| 2018-06-04 00:11:28 | cheryl.sabella | create | |