Issue36106
Created on 2019-02-25 13:47 by dimpase, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 12027 | merged | dimpase, 2019-02-25 13:47 | |
| PR 12046 | merged | miss-islington, 2019-02-26 06:36 | |
| PR 12050 | merged | dimpase, 2019-02-26 09:57 | |
| Messages (11) | |||
|---|---|---|---|
| msg336519 - (view) | Author: Dmitrii Pasechnik (dimpase) * | Date: 2019-02-25 13:47 | |
The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on FreeBSD (it has to be named "sinpi", not "sinPi", cf. e.g. https://en.cppreference.com/w/c/experimental/fpext4) |
|||
| msg336525 - (view) | Author: Emmanuel Arias (eamanu) * | Date: 2019-02-25 14:53 | |
Hi!, It seem a good improve to resolve a potential problem. But I am not convinced if that problem could appear because sinpi() is definded locally. |
|||
| msg336528 - (view) | Author: Dmitrii Pasechnik (dimpase) * | Date: 2019-02-25 15:00 | |
This has a potential header conflict. For the same reason functions like lgamma, etc. are prefixed with `m_` in Modules/mathmodule.c |
|||
| msg336529 - (view) | Author: Dmitrii Pasechnik (dimpase) * | Date: 2019-02-25 15:05 | |
e.g. if I rename `m_lgamma` to `lgamma` I get ``` mathmodule.c:389:1: error: static declaration of ‘lgamma’ follows non-static declaration lgamma(double x) ``` |
|||
| msg336618 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * | Date: 2019-02-26 06:36 | |
New changeset f57cd8288dbe6aba99c057f37ad6d58f8db75350 by Serhiy Storchaka (Dima Pasechnik) in branch 'master': bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (GH-12027) https://github.com/python/cpython/commit/f57cd8288dbe6aba99c057f37ad6d58f8db75350 |
|||
| msg336622 - (view) | Author: miss-islington (miss-islington) | Date: 2019-02-26 07:10 | |
New changeset 4e6646fef5d2cc53422e4eca0b18201ed5a5c4b6 by Miss Islington (bot) in branch '3.7': bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (GH-12027) https://github.com/python/cpython/commit/4e6646fef5d2cc53422e4eca0b18201ed5a5c4b6 |
|||
| msg336633 - (view) | Author: Kubilay Kocak (koobs) | Date: 2019-02-26 08:59 | |
Downstream issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232792 |
|||
| msg336641 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * | Date: 2019-02-26 10:41 | |
New changeset b545ba0a508a5980ab147ed2641a42be3b31a2db by Serhiy Storchaka (Dima Pasechnik) in branch '2.7': [2.7] bpo-36106: resolve sinpi name clash with libm (IEEE-754 violation). (GH-12027) (GH-12050) https://github.com/python/cpython/commit/b545ba0a508a5980ab147ed2641a42be3b31a2db |
|||
| msg336692 - (view) | Author: Mark Dickinson (mark.dickinson) * | Date: 2019-02-26 16:34 | |
This one was my fault. Thanks for the fix! |
|||
| msg340099 - (view) | Author: Dmitrii Pasechnik (dimpase) * | Date: 2019-04-12 19:15 | |
Can this also be backported to 3.5. and 3.6, as requested by FreeBSD maintainers? |
|||
| msg340110 - (view) | Author: Cheryl Sabella (cheryl.sabella) * | Date: 2019-04-12 20:33 | |
I'll nosy Ned as the release manager about the request to 3.6. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:11 | admin | set | github: 80287 |
| 2019-04-12 20:33:52 | cheryl.sabella | set | nosy:
+ cheryl.sabella, ned.deily messages: + msg340110 |
| 2019-04-12 19:15:40 | dimpase | set | messages: + msg340099 |
| 2019-02-26 16:34:18 | mark.dickinson | set | messages: + msg336692 |
| 2019-02-26 10:42:10 | serhiy.storchaka | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-02-26 10:41:18 | serhiy.storchaka | set | messages: + msg336641 |
| 2019-02-26 09:57:40 | dimpase | set | pull_requests: + pull_request12076 |
| 2019-02-26 08:59:25 | koobs | set | nosy:
+ koobs messages:
+ msg336633 |
| 2019-02-26 07:10:58 | miss-islington | set | nosy:
+ miss-islington messages: + msg336622 |
| 2019-02-26 06:36:25 | miss-islington | set | keywords:
+ patch pull_requests: + pull_request12071 |
| 2019-02-26 06:36:17 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg336618 |
| 2019-02-25 15:05:12 | dimpase | set | messages: + msg336529 |
| 2019-02-25 15:00:24 | dimpase | set | messages: + msg336528 |
| 2019-02-25 14:53:31 | eamanu | set | messages: + msg336525 |
| 2019-02-25 14:48:47 | eamanu | set | nosy:
+ eamanu |
| 2019-02-25 13:53:56 | SilentGhost | set | nosy:
+ mark.dickinson stage: patch review |
| 2019-02-25 13:47:03 | dimpase | create | |