Issue36673
Created on 2019-04-20 07:33 by scoder, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 12883 | merged | scoder, 2019-04-20 08:52 | |
| Messages (3) | |||
|---|---|---|---|
| msg340565 - (view) | Author: Stefan Behnel (scoder) * | Date: 2019-04-20 07:33 | |
The TreeBuilder in xml.etree.ElementTree ignores comments and processing instructions. It should at least have a way to pass them through, even if there is not currently a way to append comments and PIs to the tree when they appear *outside* of the root element. The pull parser interface would directly benefit from this, because it can then report "comment" and "pi" events. |
|||
| msg340566 - (view) | Author: Stefan Behnel (scoder) * | Date: 2019-04-20 07:35 | |
This is related to issue9521 but not a strict duplicate, because fixing that would require actually adding comments and PIs to the tree when they are not within the root element. When they are, it's in line with the current tree model and this change will do it. |
|||
| msg341228 - (view) | Author: Stefan Behnel (scoder) * | Date: 2019-05-01 19:21 | |
New changeset 43851a202cabce1e6be699e7177735c778b6697e by Stefan Behnel in branch 'master': bpo-36673: Implement comment/PI parsing support for the TreeBuilder in ElementTree. (#12883) https://github.com/python/cpython/commit/43851a202cabce1e6be699e7177735c778b6697e |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:14 | admin | set | github: 80854 |
| 2019-05-01 20:38:32 | scoder | set | pull_requests: - pull_request12811 |
| 2019-05-01 19:31:14 | scoder | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-05-01 19:21:00 | scoder | set | messages: + msg341228 |
| 2019-04-20 11:30:20 | scoder | set | pull_requests: + pull_request12811 |
| 2019-04-20 08:58:42 | scoder | set | nosy:
+ eli.bendersky, serhiy.storchaka |
| 2019-04-20 08:52:42 | scoder | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request12808 |
| 2019-04-20 07:35:26 | scoder | set | messages: + msg340566 |
| 2019-04-20 07:33:22 | scoder | create | |