Issue37931
Created on 2019-08-23 15:39 by Benoit Hudson, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| crashy.c | Benoit Hudson, 2019-08-23 15:39 | |||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 15428 | merged | Benoit Hudson, 2019-08-23 16:07 | |
| PR 17488 | merged | miss-islington, 2019-12-06 19:15 | |
| Messages (6) | |||
|---|---|---|---|
| msg350309 - (view) | Author: Benoit Hudson (Benoit Hudson) * | Date: 2019-08-23 15:39 | |
On OSX, with --enable-shared, if you shut down python and reinitialize, you can get a crash. Repro steps: see attached crashy.c gcc -I. -I ../Include/ -L. crashy.c -lpython3.9 ./a.out On OSX, with --enable-shared, you get a crash! On other platforms including on OSX static builds, no crash. Not a regression: it's present in 2.7 (where we actually hit it). PR incoming, the fix is simple. It has to do with caching (on OSX shared builds only) a stale value for the environment when building os.environ the first time; if you change the environment, the second initialization reads garbage when building os.environ. |
|||
| msg354387 - (view) | Author: Benoit Hudson (Benoit Hudson) * | Date: 2019-10-10 15:23 | |
Ping! The patch has been ready for review for over a month. If the patch can be backported to 2.7.x before that gets end-of-lifed it would be ideal. |
|||
| msg357940 - (view) | Author: STINNER Victor (vstinner) * | Date: 2019-12-06 19:15 | |
New changeset 723f71abf7ab0a7be394f9f7b2daa9ecdf6fb1eb by Victor Stinner (Benoit Hudson) in branch 'master': bpo-37931: Fix crash on OSX re-initializing os.environ (GH-15428) https://github.com/python/cpython/commit/723f71abf7ab0a7be394f9f7b2daa9ecdf6fb1eb |
|||
| msg357942 - (view) | Author: miss-islington (miss-islington) | Date: 2019-12-06 19:32 | |
New changeset 836cf31a3cf468ed9598a220b8e194b366287bfe by Miss Islington (bot) in branch '3.8': bpo-37931: Fix crash on OSX re-initializing os.environ (GH-15428) https://github.com/python/cpython/commit/836cf31a3cf468ed9598a220b8e194b366287bfe |
|||
| msg378789 - (view) | Author: Irit Katriel (iritkatriel) * | Date: 2020-10-16 23:23 | |
Can this be closed? |
|||
| msg378880 - (view) | Author: STINNER Victor (vstinner) * | Date: 2020-10-18 18:02 | |
Right, I close the issue. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:19 | admin | set | github: 82112 |
| 2020-10-18 18:02:08 | vstinner | set | status: open -> closed resolution: fixed messages: + msg378880 stage: patch review -> resolved |
| 2020-10-16 23:23:12 | iritkatriel | set | nosy:
+ iritkatriel messages: + msg378789 |
| 2019-12-06 19:32:39 | miss-islington | set | nosy:
+ miss-islington messages: + msg357942 |
| 2019-12-06 19:15:17 | miss-islington | set | pull_requests: + pull_request16967 |
| 2019-12-06 19:15:16 | vstinner | set | nosy:
+ vstinner messages: + msg357940 |
| 2019-10-10 15:23:12 | Benoit Hudson | set | messages:
+ msg354387 versions: + Python 2.7 |
| 2019-08-23 16:07:35 | Benoit Hudson | set | keywords:
+ patch stage: patch review pull_requests: + pull_request15125 |
| 2019-08-23 15:39:47 | Benoit Hudson | create | |