Issue 40417: PyImport_ReloadModule emits deprecation warning

It appears as though PyImport_ReloadModule is importing the deprecated "imp" module.

I integrated a newer version of Python into Unreal Engine 4, which internally calls this function for some of it's own modules. Normally a stray warning wouldn't be of much concern to me, but the process of "cooking" (converting raw assets to optimized/final assets) will fail if anything is written to stderr. This makes it impossible to package a copy of the game for testing or release without a workaround.

I'm going to add a test to _testembed.c to verify my fix. Is this something that I should include in the Github PR?

Yeah, that looks like an oversight.  I've approved your PR.  Thanks!

Did you have a need for this to be fixed in 3.8 or earlier?  This seems reasonably and simple enough to backport.  I suppose someone could be relying on an implicit import of the "imp" module, but that seems highly unlikely and suspect anyway. :)

We have a fairly straightforward workaround of using the "warnings" module
to redirect to stdout, so we personally don't have a need.

Unreal, however, follows the VFX Reference Platform (
https://vfxplatform.com/) which is migrating from 2.7 to 3.7.x this year.
They will likely run into this during their migration, so backporting to
3.7 would be useful.

On Fri, May 1, 2020 at 8:22 AM Eric Snow <report@bugs.python.org> wrote:

>
> Eric Snow <ericsnowcurrently@gmail.com> added the comment:
>
> Did you have a need for this to be fixed in 3.8 or earlier?  This seems
> reasonably and simple enough to backport.  I suppose someone could be
> relying on an implicit import of the "imp" module, but that seems highly
> unlikely and suspect anyway. :)
>
> ----------
> nosy: +brett.cannon, ncoghlan
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <https://bugs.python.org/issue40417>
> _______________________________________
>

New changeset f40bd466bf14029e2687e36e965875adf9d4be1a by Robert Rouhani in branch 'master':
bpo-40417: Fix deprecation warning in PyImport_ReloadModule (GH-19750)
https://github.com/python/cpython/commit/f40bd466bf14029e2687e36e965875adf9d4be1a

This can't be backported cleanly. If you're up for making PRs for 3.8 and 3.7, Robert, we can look at applying them.

New changeset a32587a60da5939a3932bb30432d2bdd3d6203d4 by Robert Rouhani in branch '3.8':
[3.8] bpo-40417: Fix deprecation warning in PyImport_ReloadModule (GH-19750) (GH-19934)
https://github.com/python/cpython/commit/a32587a60da5939a3932bb30432d2bdd3d6203d4

New changeset d64fd617e02346ecbcba9559f227936e08e89602 by Robert Rouhani in branch '3.7':
[3.7] bpo-40417: Fix deprecation warning in PyImport_ReloadModule (GH-19750) (GH-19935)
https://github.com/python/cpython/commit/d64fd617e02346ecbcba9559f227936e08e89602

Thanks for all your hard work, Robert!

No problem! Happy to contribute where I can :)

stage: patch review -> resolved

pull_requests: + pull_request19071
stage: patch review